-
Notifications
You must be signed in to change notification settings - Fork 475
standard tool annotation classes #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
scottslewis
wants to merge
13
commits into
modelcontextprotocol:main
Choose a base branch
from
scottslewis:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to address feature request: modelcontextprotocol#224
annotation classes. Added ToolResult, ToolAnnotation, and ToolAnnotations annotations. Added ToolGroupService interface and supporting tools.utils.*Description classes, to allow runtime querying of an service interface class' ToolDescriptions (one for each method with Tool annotation at runtime).
@tool, @ToolParam, @ToolResult, @ToolAnnotations along with description (record) classes...e.g. ToolDescription for communicating the meta-data across processes in a consistent way.
This was referenced Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #224
New annotation classes for @tool, @ToolParam, @ToolAnnotations, @ToolResult annotations.
Motivation and Context
Currently, each framework vendor (e.g. Spring, others) is defining it's own Java annotation classes, which binds (by package namespace) these annotations to a specific framework. Including these as part of the java mcp sdk will allow developers to use any framework rather than bind these classes to a specific framework.
How Has This Been Tested?
Have tested here: https://github.com/ECF/Py4j-RemoteServicesProvider/blob/master/examples/org.eclipse.ecf.examples.ai.mcp.toolservice/src/org/eclipse/ecf/examples/ai/mcp/toolservice/ArithmeticTools.java
If accepted, I will contribute automated tests. The existing annotation and *Description classes have been tested.
Breaking Changes
Only breaking changes will be for developers that are using the framework-specific annotations currently.
Yes as per above.
Types of changes
Checklist